-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Unify widget icon colors and document it's behaviour #46448
Merged
AndyScherzinger
merged 3 commits into
master
from
bugfix/noid/fix-missing-dashboard-widget-icon
Jul 11, 2024
Merged
fix(dashboard): Unify widget icon colors and document it's behaviour #46448
AndyScherzinger
merged 3 commits into
master
from
bugfix/noid/fix-missing-dashboard-widget-icon
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
design
Design, UI, UX, etc.
3. to review
Waiting for reviews
feature: dashboard
labels
Jul 11, 2024
This was referenced Jul 11, 2024
jancborchardt
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice design fix, thank you! (Screenshots checked, not tested)
AndyScherzinger
approved these changes
Jul 11, 2024
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
AndyScherzinger
force-pushed
the
bugfix/noid/fix-missing-dashboard-widget-icon
branch
from
July 11, 2024 12:18
3f1e79d
to
22b237b
Compare
/compile amend/ |
Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
bugfix/noid/fix-missing-dashboard-widget-icon
branch
from
July 11, 2024 13:14
22b237b
to
37d3312
Compare
AndyScherzinger
deleted the
bugfix/noid/fix-missing-dashboard-widget-icon
branch
July 11, 2024 15:27
/backport to stable29 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently apps provide different icons and backgrounds via CSS classes. Some dark, some white. Some automatically invert the color based on dark mode, some don't, …
This caused endless fixing of icons and the general framework multiple times, so now here is the final outcome:
Get the absolute url for the widget icon (should be colored black or not have a color).
The icon will be inverted automatically in mobile clients and when using dark mode
The icon will be inverted automatically in mobile clients and when using dark mode.
Therefore, it is NOT recommended to use a css class that sets the background with:
var(--icon-…)
as those will adapt to dark/bright mode in the web and still be invertedresulting in a dark icon on dark background.
Also the widget ID is used as css class, so I documented limitation of characters and log a debug if it's not matching
Get a unique identifier for the widget
To ensure uniqueness, it is recommended to user the app id or start with the app id followed by a dash.
@return
string Unique id that identifies the widget, e.g. the app id. Only use alphanumeric characters, dash and underscoreScreenshots
Apps that need fixing
Checklist