Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid updating size when calling touch on a file #45233

Merged
merged 1 commit into from
May 13, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented May 8, 2024

When trying to figure out a different issue I noticed that when calling touch to create an empty file we always calculate and update the size of parent folders. However as we know the file is just touched, we can pass the sizeDifference of 0 along for writing the update to the cache to avoid unneeded size calculation/updates.

Earlier change that introduced the shortcut #42597

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr requested review from Altahrim, a team, ArtificialOwl, yemkareems and come-nc and removed request for a team May 8, 2024 10:34
@juliusknorr juliusknorr added this to the Nextcloud 30 milestone May 8, 2024
@juliusknorr juliusknorr self-assigned this May 10, 2024
@come-nc come-nc merged commit 2d40dae into master May 13, 2024
157 checks passed
@come-nc come-nc deleted the fix/touch-propagate-size branch May 13, 2024 09:48
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants