Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix: avoid douple expireDate parsing #44912

Merged
merged 3 commits into from
Jun 11, 2024
Merged

[stable28] fix: avoid douple expireDate parsing #44912

merged 3 commits into from
Jun 11, 2024

Commits on Jun 10, 2024

  1. refactor(shareApiController): use contrusctor property promotion & DI… 

    … logger

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    30900ae View commit details
    Browse the repository at this point in the history

  2. fix(shareApiController): avoid duplicated expiryDate operations 

    `expireDate` can be set once and used anywhere needed, the current implementation,

duplicates this behavior which leads to `parseDate` receiving an a date object it

parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3c50777 View commit details
    Browse the repository at this point in the history

  3. fix(sharing): Don't change the type of the controller argument 

    [EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @nickvergessen @Fenn-CS
    nickvergessen authored and Fenn-CS committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    4d748b9 View commit details
    Browse the repository at this point in the history