Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect empty expiryDate value in server #44485

Merged
merged 3 commits into from
May 23, 2024
Merged

Respect empty expiryDate value in server #44485

merged 3 commits into from
May 23, 2024
+191 −170

Commits on May 23, 2024

  1. fix(shareManager): Respect empty expireDate in server 

    If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed May 23, 2024
    Configuration menu
    Copy the full SHA
    59a5b4e View commit details
    Browse the repository at this point in the history

  2. refactor(shareManager): Use constructor property promotion 

    Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f5a433f View commit details
    Browse the repository at this point in the history

  3. test(Sharing): Integration test for no expiration set date for share 

    - Verify that explicitly sending empty `expireDate` param to server overwrite default
and sets not expiry date, if non is enforced.

- Update tests to avoid converting empty string to date.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS
    Fenn-CS committed May 23, 2024
    Configuration menu
    Copy the full SHA
    d41d885 View commit details
    Browse the repository at this point in the history