-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable23] Forbid tagging readonly files #44326
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
25 supports 7.4 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@@ -60,10 +60,19 @@ | |||
$tagMapper, | |||
$userSession, | |||
$groupManager, | |||
function ($name) { | |||
function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
$nodes = \OC::$server->getUserFolder()->getById((int)$name); | ||
return !empty($nodes); | ||
} | ||
}, | ||
function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
} | ||
}, | ||
function ($name): bool { | ||
$nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
} | ||
}, | ||
function ($name): bool { | ||
$nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
23 still supports PHP 7.3 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
|
apps/dav/tests/unit/SystemTag/SystemTagsObjectMappingCollectionTest.php
Outdated
Show resolved
Hide resolved
… 7.3 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
355a6f1
to
a4473ce
Compare
Backport of PR #44309 / #44297