Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure nested mount points are handled in the correct order #44279

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

icewind1991
Copy link
Member

Otherwise etag propagation across nested mountpoints won't behave correctly.

To test:

  • Create groupfolders gf1, gf1/gf2 and gf1/gf2/gf3
  • Apply the patch, but change the order of $a and $b around to change the sort order to be intentionally wrong
  • do a propfind with Depth: 1 on gf1 and on gf1/gf2
    • Note that the etag for gf1/gf2 differs between the two requests
  • Restore the correct sort order by changing $a and $b back
  • do a propfind with Depth: 1 on gf1 and on gf1/gf2
    • The etag for gf1/gf2 should now be the same between the two requests

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 18, 2024
@icewind1991 icewind1991 added this to the Nextcloud 29 milestone Mar 18, 2024
@icewind1991 icewind1991 requested review from come-nc, a team, ArtificialOwl and artonge and removed request for a team March 18, 2024 15:26
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense.
Any idea how they could be in the wrong order in the first place?

@icewind1991
Copy link
Member Author

Any idea how they could be in the wrong order in the first place?

Did some more testing and it seems to be just the order the groupfolders were created in.

So if you create gf1/gf2 before gf1 it would trigger the bug.

@Altahrim Altahrim mentioned this pull request Mar 18, 2024
@icewind1991
Copy link
Member Author

/backport to stable28

@icewind1991
Copy link
Member Author

/backport to stable27

@icewind1991
Copy link
Member Author

/backport to stable26

Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants