enh(setting): Migrate OCM / OCS provider tests to SetupCheck #43607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nickvergessen,
come-nc,
a team,
ArtificialOwl and
sorbaugh
and removed request for
a team
susnux
force-pushed
the
enh/migrate-ocx-providers-setupcheck
branch
from
0ffcfb4
to
47d3b01
Compare
come-nc
previously requested changes
Feb 19, 2024
33 tasks
susnux
force-pushed
the
enh/migrate-ocx-providers-setupcheck
branch
from
839e065
to
81d06b4
Compare
susnux
force-pushed
the
enh/migrate-ocx-providers-setupcheck
branch
2 times, most recently
from
e6ac052
to
0b9e267
Compare
|
Resolved all comments, please re-review :) |
skjnldsv
approved these changes
Feb 27, 2024
- enh(setting): Migrate OCM / OCS provider tests to SetupCheck
+ feat(setting): Migrate OCM / OCS provider tests to SetupCheck |
come-nc
approved these changes
Feb 27, 2024
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
enh/migrate-ocx-providers-setupcheck
branch
from
0b9e267
to
2e8c9f2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate the ocs-provider and ocm-provider from legacy to SetupCheck.
Checklist