Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(files): Allow to copy files into same directory #42889

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 17, 2024

Summary

Bring back copy to current directory behavior which will clone the file and add a "copy" suffix on the file name.

Checklist

@susnux susnux force-pushed the fix/copy-in-same-dir branch 3 times, most recently from 2034ea9 to d5427fc Compare January 18, 2024 01:53
@susnux susnux marked this pull request as ready for review January 18, 2024 11:25
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Jan 18, 2024
@susnux susnux added this to the Nextcloud 29 milestone Jan 18, 2024
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the file part and it LGTM!!

@susnux susnux force-pushed the fix/copy-in-same-dir branch 2 times, most recently from ed6589c to 8d835e1 Compare January 19, 2024 19:26
@susnux
Copy link
Contributor Author

susnux commented Jan 19, 2024

@emoral435 can you check again if that still happens for you?

@susnux susnux requested a review from emoral435 January 19, 2024 19:26
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked, and it works perfectly for me now :) sorry for being nitpicky!

@emoral435
Copy link
Contributor

@skjnldsv before we merge this in, it still says that you have requested changes. I'm 99% sure your fine with this, but just to make sure, all the changes now are fine by you, correct? :)

@skjnldsv skjnldsv removed the 3. to review Waiting for reviews label Jan 20, 2024
@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 20, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…py-move-action

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux enabled auto-merge January 20, 2024 14:42
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@skjnldsv
Copy link
Member

/backport eaad30c b29c0cc a289fdd to stable28

@skjnldsv skjnldsv merged commit 87ae14e into master Jan 20, 2024
40 of 41 checks passed
@skjnldsv skjnldsv deleted the fix/copy-in-same-dir branch January 20, 2024 15:05
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files regression
Projects
None yet
4 participants