Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] sidebar: allow turning off tags view by default #42782

Closed
wants to merge 1 commit into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jan 15, 2024

Backport of #40939

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove [skip ci] tag

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Jan 15, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.2 milestone Jan 15, 2024
@blizzz blizzz mentioned this pull request Jan 15, 2024
This was referenced Feb 14, 2024
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 29, 2024
@Altahrim Altahrim mentioned this pull request Mar 21, 2024
9 tasks
@solracsf
Copy link
Member

solracsf commented Jul 4, 2024

/compile amend /

@solracsf solracsf marked this pull request as ready for review July 4, 2024 07:37
@solracsf solracsf added 3. to review Waiting for reviews feature: tags and removed 2. developing Work in progress labels Jul 4, 2024
With #37065, there is no way to hide the tags from the sidebar

by default when they are not relevant or redundant (e.g. the tab

may already show the file's tags). This can be annyoing especially

when the file has many tags. This patch adds an option to hide

the tags from the sidebar by default (the user can still open

the tags tab manually).

This also reduces one request when opening the sidebar when the

tags are turned off, since all tags don't need to be fetched

anymore.

Signed-off-by: Varun Patil <varunpatil@ucla.edu>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@solracsf
Copy link
Member

solracsf commented Jul 4, 2024

Re-backporting.

@solracsf solracsf closed this Jul 4, 2024
@solracsf solracsf deleted the backport/40939/stable28 branch July 4, 2024 07:47
@solracsf solracsf removed this from the Nextcloud 28.0.8 milestone Jul 4, 2024
@solracsf solracsf restored the backport/40939/stable28 branch July 5, 2024 06:58
@solracsf solracsf reopened this Jul 5, 2024
@solracsf solracsf closed this Jul 5, 2024
@solracsf solracsf deleted the backport/40939/stable28 branch July 5, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants