Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certificate manager fallback #42763

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Certificate manager fallback #42763

wants to merge 2 commits into from
+144 −2

Commits on Feb 1, 2024

  1. fix(certificate manager): migrate certificate bundles from files_exte… 

    …rnal to data

CertificateManager doesn't work propertly if the files_external app is disabled, so let's store
directly in /data/certificate_manager the bundled certificates. This always has to be done on local
disk as curl currently requires a path to the cert bundle.

When we require PHP 8.1 we will be able to simply store the certificate
bundle in database/memory/cache and pass it through the CURLOPT_SSLCERT_BLOB option.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
    @tcitworld
    tcitworld committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    dd54f35 View commit details
    Browse the repository at this point in the history

  2. refactor(certificate manager): remove unused variable 

    Signed-off-by: Thomas Citharel <tcit@tcit.fr>
    @tcitworld
    tcitworld committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    1171f3c View commit details
    Browse the repository at this point in the history