-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(update-section): changed span to an interactive element #42744
fix(update-section): changed span to an interactive element #42744
Conversation
/backport to stable28 |
@@ -85,7 +85,7 @@ | |||
</template> | |||
<template v-else> | |||
{{ t('updatenotification', 'Your version is up to date.') }} | |||
<span :title="lastCheckedOnString" :aria-label="lastCheckedOnString" class="icon-info svg" /> | |||
<a :title="lastCheckedOnString" :aria-label="lastCheckedOnString" href="https://nextcloud.com/changelog/" class="icon-info details"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it should be target="_blank"
, same as the second one is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add aria-label
to all links for following pages:
- settings/user/sharing - aria-label
- settings/user/workflow
- settings/admin/overview
- settings/admin
- settings/admin/sharing
- settings/admin/security
- settings/admin/theming
- settings/admin/groupware
- settings/admin/admindelegation
- settings/admin/workflow
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
7ad8387
to
a671c51
Compare
Because some of those issues need changes from other libraries, im splitting this issue into another issue @JuliaKirschenheuter , but I will still work on it right now :) all this needs now is a re-review ! |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
* Resolves: #42637
Summary
Changes span to a link element, similar to how the above information button is like within the page!
Checklist