-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh FileList on current folder update #42382
Refresh FileList on current folder update #42382
Conversation
/backport to stable28 |
/compile |
b88cf8f
to
9cc8c68
Compare
This PR won't work because the function names mismatch: subscribe() uses "onUpdateNode", but actual name is "onUpdatedNode". |
1d5617e
to
b3bf1cf
Compare
Nice catch @hschletz! I have now fixed it and tested again using my app which already integrates the changes: https://github.com/Raudius/files_scripts/blob/master/src/files.ts#L10 |
@Raudius please rebase and compile again, then it will be good to merge :) |
Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com> Signed-off-by: Raul Ferreira Fuentes <Raudius@users.noreply.github.com>
75d22dc
to
bced164
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com> Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
bced164
to
cf415bf
Compare
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Summary
This PR subscribes the
FileList
view to the file-updated event. If the file updated matches the current folder it re-fetches the current view.Checklist