Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Handle close GlobalSearchModal gracefully #41792 #41930

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[stable28] Handle close GlobalSearchModal gracefully #41792 #41930

merged 1 commit into from
Nov 30, 2023

Commits on Nov 30, 2023

  1. Handle close GlobalSearchModal gracefully 

    The current close infrastructure modifies a prop which has
 no real effect aside bugs.

In addition, calling the `NcModal.close()` as the primary way to
 close the search modal instead of using the states defined in `GlobalSearch` view
 causing re-open bugs (Modal cannot open, needs to click twice, and other weird stuff).

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @Fenn-CS @nextcloud-command
    Fenn-CS authored and nextcloud-command committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    daafc73 View commit details
    Browse the repository at this point in the history