Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] ci(acceptance): fix dev branch #41689

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 23, 2023

Fixes

ParseError: syntax error, unexpected 'protected' (T_PROTECTED), expecting variable (T_VARIABLE) in /drone/src/apps/notifications/lib/Push.php:133

errors on drone.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added 3. to review Waiting for reviews CI labels Nov 23, 2023
@blizzz blizzz requested review from nickvergessen, AndyScherzinger, a team, szaimen, sorbaugh and emoral435 and removed request for a team November 23, 2023 13:04
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch! 👍

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 23, 2023
@blizzz blizzz merged commit 25dad2e into stable25 Nov 23, 2023
28 of 30 checks passed
@blizzz blizzz deleted the fix/noid/fix-dev-branch branch November 23, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants