-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements : improve most recent global search UI #41384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
force-pushed
the
41381-global-search-follow-up
branch
from
November 10, 2023 17:54
e6032af
to
97d5956
Compare
Merged
Design review notes High
Medium
Low
|
Performance
UI
|
Fenn-CS
force-pushed
the
41381-global-search-follow-up
branch
5 times, most recently
from
November 14, 2023 17:15
66f14b0
to
abf4d32
Compare
AndyScherzinger
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't judge, but 👍 for merging the improvements for beta3 build
FYI : @blizzz and others, open items on this ticket would be moved to the a new PR and issue would open (or re-opened). For beta3 merge considerations |
/compile amend / |
Pytal
approved these changes
Nov 14, 2023
- Fixes remove person filter/chip when applied - Close person searchable filter via workaround - Person filter has no effect fixed, now uses user property instead of id - Left align filters - Reduce avatar size in user chip and make photo non-clickable Resolves : #41381 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Show some feedback when there are no search results. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
41381-global-search-follow-up
branch
from
November 14, 2023 19:29
abf4d32
to
a95396e
Compare
/compile amend / |
Only show in-app serach button if available for specific app in question. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
41381-global-search-follow-up
branch
from
November 14, 2023 20:07
a95396e
to
987ac1e
Compare
blizzz
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
2. developing
Work in progress
labels
Nov 14, 2023
susnux
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #41381
TODO
From @ChristophWurst