Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(f2v): Migrate unread comments action to the new FileAction API #40409

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

lhsazevedo
Copy link
Contributor

Summary

Migrate inline unread comments action to the new FileAction API.

To display the inline action as a icon only button, I had to remove the force-name prop from the <NcActions /> in the FileEntry.vue, otherwise the NcButton is rendered with text as well. But I imagine the action buttons were meant to be icon only, so I guess this was unintentionally added?

Screenshots

image
image

TODO

  • Hide action after opening the sidebar. Should I use Vue.set() to overwrite the comments-unread attribute and rely on reactivity to disable the action?

Checklist

@skjnldsv skjnldsv requested review from a team, susnux, Pytal and artonge and removed request for a team September 16, 2023 10:35
@skjnldsv skjnldsv mentioned this pull request Sep 16, 2023
26 tasks
@skjnldsv
Copy link
Member

To display the inline action as a icon only button, I had to remove the force-name prop from the in the FileEntry.vue, otherwise the NcButton is rendered with text as well. But I imagine the action buttons were meant to be icon only, so I guess this was unintentionally added?

Maybe, I don't recall. We'll see if that causes issues later on! Let get this merged :)

@skjnldsv skjnldsv force-pushed the feat/f2v-unread-comments-action branch from dd2a85e to 3791adf Compare September 16, 2023 11:48
@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv skjnldsv force-pushed the feat/f2v-unread-comments-action branch from 3791adf to 6bfd91e Compare September 16, 2023 12:00
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 16, 2023
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
@skjnldsv skjnldsv force-pushed the feat/f2v-unread-comments-action branch from 6bfd91e to 03ece12 Compare September 16, 2023 12:09
@skjnldsv skjnldsv merged commit 006f5d0 into master Sep 16, 2023
36 of 39 checks passed
@skjnldsv skjnldsv deleted the feat/f2v-unread-comments-action branch September 16, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: comments feature: files
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants