Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Backport Polish new sharing flow : accesibility, expand bahavior, click outside behaviour #40327

Merged
merged 4 commits into from
Sep 7, 2023
Merged

[stable27] Backport Polish new sharing flow : accesibility, expand bahavior, click outside behaviour #40327

merged 4 commits into from
Sep 7, 2023

Commits on Sep 7, 2023

  1. Do not toggle custom permissions 

    Currently, swithcing between permissions in the sharing permissions
details view would toggle the custom permissions view.

We think, it's better for the custom permission option to simple
expand the custom permissions view and never close it gain even if the
user is switching between bundled permissions.

The user can always collapse the view by using the "Advanced settings" toggle.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS @blizzz
    Fenn-CS authored and blizzz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    c22c9c9 View commit details
    Browse the repository at this point in the history

  2. Close quickshare dropdown on outside click 

    If a user clicks anywhere outside of the quickshare dropdown,
it should be closed.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS @blizzz
    Fenn-CS authored and blizzz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    8fab354 View commit details
    Browse the repository at this point in the history

  3. Add accesibility features to quick share dropdown 

    - Adds appropriate aria attributes
- Uses button element for dropdown items as it's more semantically correct
- Uses trap-focus lib to trap focus when the drowpdown is active
- Adds custom handling for arrow up and down

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS @blizzz
    Fenn-CS authored and blizzz committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    1539d5e View commit details
    Browse the repository at this point in the history

  4. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @nextcloud-command
    nextcloud-command committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    c0b97ea View commit details
    Browse the repository at this point in the history