-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appframework): Expose programmatic rate limiter #40288
Conversation
* | ||
* @since 28.0.0 | ||
*/ | ||
interface IRateLimitExceededException extends Throwable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deliberately exposed an interface not an implementation to avoid a https://en.wikipedia.org/wiki/Fragile_base_class
public function registerUserRequest(string $identifier, | ||
int $userLimit, | ||
int $userPeriod, | ||
IUser $user): void;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IUser $user): void;} | |
IUser $user): void; | |
} |
So, CS and we are ready to go |
3a745f3
to
5253bd4
Compare
5253bd4
to
299bd18
Compare
Autoloader missing an update |
299bd18
to
1a3a32a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing alias registration
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
1a3a32a
to
e477bb7
Compare
Summary
We can't use rate limiting outside app framwork controllers. Now we can.
TODO
Checklist