-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[f2v] Render inline system tags using new DAV properties API #40284
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Done! Added some tests as well. For now I'm hiding the tags on mobile using CSS media queries, as I'm not sure if registering an size observer inside Unfortunately the tags aren't being rendered on the initial DAV request after moving to the inline-system-tags-bug.mp4I believe it isn't possible to register the property earlier while still in the |
Media queries is how it should be done.
We actually discovered that with @juliushaertl yesterday and worked on a fix, you can ignore it :) |
Not sure if the complexity trade off is worth it... We'll probably consume them in other places of the app soon, so I guess it's Ok for them to be available on mobile as well for now? |
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
3e534b3
to
f586521
Compare
Ref: #39914 #37938
Summary
Display inline system tags using the new DAV properties API.
I kept the action in the files app since the previous plugin was in there as well, and I didn't found any action registration outside the files* apps. But I can move it to the
systemtags
app if that is preferred!TODO
systemtags
appChecklist
Documentation (manuals or wiki) has been updated or is not requiredBackports requested where applicable (ex: critical bugfixes)