-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add switch to disable dns pinning #40108
Conversation
/backport to stable27 |
/backport to stable26 |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
a186682
to
eab46bd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit sad to come to this, but I don't have a better solution for now ^^
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport to stable25 |
Summary
A hard requirement for DNS pinning is the ability to resolve DNS records.
If resolving DNS records is not possible, DNS pinning cannot work.
HTTP proxy => DNS names are resolved via proxy (c.f. https://everything.curl.dev/libcurl/proxies#local-or-proxy-name-lookup). That explains, why outgoing connections work without the possibility to resolve DNS records locally.
TODO
Checklist