-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: encode basename in restore action #39842
Conversation
/backport to stable27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There might be many locations where this would be needed then 🤔
I guess ;) |
90731c2
to
60ffb68
Compare
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
60ffb68
to
7183e3d
Compare
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
stable27: #39842 |
Summary
As per https://xhr.spec.whatwg.org/#the-setrequestheader()-method and https://infra.spec.whatwg.org/#byte-sequences the header value must be in the range 0x20 (SP) to 0x7E (~) hence we need to encode everything else.
TODO
Checklist