Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppEcosystem Authentification #39655

Merged
merged 3 commits into from
Aug 10, 2023
Merged

AppEcosystem Authentification #39655

merged 3 commits into from
Aug 10, 2023

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Aug 1, 2023

  • Adds: new way of authentication for external applications.

Summary

It's a draft for tomorrow's AppEcosystem call.
This is all that is needed (minimum changes) to authenticate applications that will be written for the new Appecosystem.

It is desirable that before the next releases this would already be included, starting from the 26th version of the cloud. (AppEcosystem is developed only for 26+ versions)

TODO

  • Nothing, we had tested it for two month, here will be no changes, it is enough for this.

Checklist

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
lib/base.php Fixed Show fixed Hide fixed
@juliusknorr
Copy link
Member

As talked in the call, i think the cleanest approach would be be to have a AuthenticationProvider interface that apps can implement an register their authentication services then, however since there are plans to move this to OCP anyways it might be ok for now to:

  • Add the unknown class as a stub for psalm
  • Wrap the Server::get with a try/catch as DI might still fail
  • Leave a hint for furture code readers about the reasoning

@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Aug 10, 2023
@AndyScherzinger
Copy link
Member

/backport to stable27

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndyScherzinger AndyScherzinger mentioned this pull request Aug 10, 2023
2 tasks
@AndyScherzinger AndyScherzinger merged commit a38a86e into master Aug 10, 2023
38 checks passed
@AndyScherzinger AndyScherzinger deleted the appecosystem-auth branch August 10, 2023 17:11
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

bigcat88 added a commit to cloud-py-api/nc_py_api that referenced this pull request Aug 10, 2023
As this was merged, we do not need Authentication patch anymore for
Nextcloud core.

nextcloud/server/pull/39655

---------

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88 added a commit to nextcloud/app_api that referenced this pull request Aug 10, 2023
As this was merged, we do not need Authentication patch anymore for
Nextcloud core.

nextcloud/server#39655

---------

Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants