Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: copy-and-delete fallback should use unlink #39644

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: copy-and-delete fallback should use unlink #39644

merged 1 commit into from
Aug 14, 2023

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 31, 2023 •
edited
Loading

Follow-up for #38623

Summary

rmdir does not work for files 🙈

To test

  • Comment the rename() block
  • Try to upload a file
  • copy works, rmdir files because a directory is expected

TODO

  • CI

Checklist

@kesselb
fix: copy-and-delete fallback should use unlink
f1d4f7c 
because rmdir does not work for files.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb self-assigned this Jul 31, 2023
@kesselb kesselb added bug 3. to review Waiting for reviews labels Jul 31, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Jul 31, 2023
szaimen
szaimen approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation makes sense but didnt test

@kesselb kesselb mentioned this pull request Aug 14, 2023
Merged
5 tasks
@kesselb kesselb merged commit 2ea6c53 into master Aug 14, 2023
38 checks passed
@kesselb kesselb deleted the fix/noid/copy-delete-fallback-for-files branch August 14, 2023 10:29
@joshtrichards joshtrichards mentioned this pull request Nov 19, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@kesselb kesselb

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@kesselb @szaimen @come-nc