Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Remove duplicated outline on file name of vue file list #39609

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 28, 2023

Summary

Currently the file list (vue) does have duplicated / interfering outlines on focus-visible:

before after
image image

Checklist

@susnux susnux requested review from jancborchardt, skjnldsv, a team, Pytal and szaimen and removed request for a team July 28, 2023 10:01
@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews files2vue labels Jul 28, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen szaimen added this to the Nextcloud 28 milestone Jul 28, 2023
@susnux susnux force-pushed the fix/focus-outline-favorites-view branch from 97d5743 to 3517fd2 Compare August 2, 2023 00:04
@susnux susnux enabled auto-merge August 2, 2023 00:04
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/focus-outline-favorites-view branch from 3517fd2 to 88bbf38 Compare August 2, 2023 00:56
@susnux susnux disabled auto-merge August 2, 2023 01:28
@susnux susnux merged commit 6ec35e3 into master Aug 2, 2023
36 checks passed
@susnux susnux deleted the fix/focus-outline-favorites-view branch August 2, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants