Typed events for db:add-missing-… #39487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
the
pending documentation
|
Unrelated, but interesting: If you put your instance into maintenance mode to add missing indexes, apps cannot register their indexes because the app and event listener are not loaded, and the index is not added.1 Footnotes |
nickvergessen
force-pushed
the
feat/noid/typed-events-for-db_add-missing
branch
from
d83bb94
to
96b1af7
Compare
come-nc
reviewed
Jul 20, 2023
juliusknorr
reviewed
Jul 20, 2023
| } | ||
| ); | ||
| $eventDispatcher->addListener(AddMissingIndicesEvent::class, function (AddMissingIndicesEvent $event) { | ||
| $event->addMissingIndex( |
There was a problem hiding this comment.
Maybe move this out to a dedicated listener class for core?
There was a problem hiding this comment.
Can we do that in a follow up? Just trying to get closer to #38546 ^_^
cleaning up the core application is something for another day
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/noid/typed-events-for-db_add-missing
branch
from
492d612
to
ab70bbd
Compare
ChristophWurst
approved these changes
Jul 24, 2023
miaulalala
approved these changes
Jul 25, 2023
bigcat88
approved these changes
Jul 25, 2023
nickvergessen
changed the title
15 tasks
nickvergessen
removed
the
pending documentation
|
Docs in nextcloud/documentation#10858 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
IEventDispatcherthat allows to dispatch symfony'sGenericEvent. However that one is also deprecated and will be dropped sooner or later. From my POV introducing yet another legacy layer is just too much (especially since I couldn't find any listeners), and dropping is the better option.Checklist