Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] feat: Add public event for missing indices #39396

Merged
merged 1 commit into from
Jul 17, 2023
Merged

[stable27] feat: Add public event for missing indices #39396

merged 1 commit into from
Jul 17, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 14, 2023 •
edited
Loading

Backport of #39389
Required for nextcloud/text#4521

@juliusknorr
feat: Add public event for missing indices
18db96c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug 2. developing Work in progress labels Jul 14, 2023
@juliusknorr juliusknorr added this to the Nextcloud 27.0.1 milestone Jul 14, 2023
@juliusknorr juliusknorr mentioned this pull request Jul 14, 2023
Merged
@juliusknorr juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 17, 2023
mejo-
mejo- approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look legit when compared with the original PR.

mejo-
mejo- approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible when compared to the original PR.

@juliusknorr
Copy link
Member Author

Psalm also fails unrelated on the base branch

@juliusknorr juliusknorr merged commit 83f7ea0 into stable27 Jul 17, 2023
33 of 35 checks passed
@juliusknorr juliusknorr deleted the backport/39389/stable27 branch July 17, 2023 09:26
@blizzz blizzz mentioned this pull request Jul 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mejo- mejo- mejo- approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @nickvergessen @mejo-