-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate federated file sharing to PSR LoggerInterface #39160
Migrate federated file sharing to PSR LoggerInterface #39160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
4edde7b
to
65ae5cf
Compare
e61884c
to
b8295db
Compare
b8295db
to
0cda7d0
Compare
apps/federatedfilesharing/lib/Controller/MountPublicLinkController.php
Outdated
Show resolved
Hide resolved
apps/federatedfilesharing/tests/Controller/MountPublicLinkControllerTest.php
Show resolved
Hide resolved
apps/federatedfilesharing/tests/Controller/MountPublicLinkControllerTest.php
Outdated
Show resolved
Hide resolved
0cda7d0
to
fd97966
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
fd97966
to
45b3f6e
Compare
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
See #32127
Summary
Remove
OCP\ILogger
fromapps/federatedfilesharing
and use Psr\Log\LoggerInterface` instead.