Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] fix(l10n): Fix plural issue with different locale and language #39032

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

nickvergessen
Copy link
Member

Backport #38917

We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jun 27, 2023
@nickvergessen nickvergessen added this to the Nextcloud 25.0.9 milestone Jun 27, 2023
@nickvergessen nickvergessen self-assigned this Jun 27, 2023
@blizzz blizzz mentioned this pull request Jul 10, 2023
@blizzz blizzz merged commit 6b79c81 into stable25 Jul 10, 2023
@blizzz blizzz deleted the backport/38917/stable25 branch July 10, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants