Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[f2v] Rename, favorite and edit locally actions #38939

Merged
merged 5 commits into from
Jun 22, 2023
Merged

[f2v] Rename, favorite and edit locally actions #38939

merged 5 commits into from
Jun 22, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 22, 2023 •
edited
Loading

  • Edit locally
  • Favorite
  • Rename

Coverage 100%

-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------
File                         | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                           
-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------
All files                    |     100 |      100 |     100 |     100 |                                
 apps/files/src/actions      |     100 |      100 |     100 |     100 |                                                             
  deleteAction.ts            |     100 |      100 |     100 |     100 |                                                             
  downloadAction.ts          |     100 |      100 |     100 |     100 |                                                             
  editLocallyAction.ts       |     100 |      100 |     100 |     100 |                                                             
  favoriteAction.ts          |     100 |      100 |     100 |     100 |                                                             
  openFolderAction.ts        |     100 |      100 |     100 |     100 |                                                             
  renameAction.ts            |     100 |      100 |     100 |     100 |                                                             
  sidebarAction.ts           |     100 |      100 |     100 |     100 |                                                             
-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Jun 22, 2023
@skjnldsv skjnldsv requested a review from a team June 22, 2023 08:40
@skjnldsv skjnldsv self-assigned this Jun 22, 2023
@skjnldsv skjnldsv requested review from susnux, Fenn-CS and Pytal and removed request for a team June 22, 2023 08:40
@skjnldsv skjnldsv changed the title feat: add edit locally action with tests [f2v] Rename, favorite and edit locally actions Jun 22, 2023
@skjnldsv skjnldsv mentioned this pull request Jun 22, 2023
Closed
6 tasks
@skjnldsv
feat: add edit locally action with tests
1112963 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv requested a review from artonge June 22, 2023 09:51
@skjnldsv
feat: add favorite action with tests
723edb5 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(files): action default is false if not set
05bfab2 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add rename action with tests
135929c 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv requested a review from artonge June 22, 2023 16:37
@skjnldsv

This comment was marked as resolved.

Sign in to view
@nextcloud-command
chore(assets): Recompile assets
cbc0f5e 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv enabled auto-merge June 22, 2023 18:33
susnux
susnux approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@skjnldsv skjnldsv merged commit 6234b09 into master Jun 22, 2023
@skjnldsv skjnldsv deleted the feat/f2v/more-actions branch June 22, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @susnux @artonge @nextcloud-command