Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add files actions testing + code coverage #38806

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Add files actions testing + code coverage #38806

merged 10 commits into from
Jun 21, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jun 14, 2023 •
edited
Loading

  • Sidebar action
  • Delete action
  • Download action
  • Open folder action

Coverage: https://app.codecov.io/gh/nextcloud/server/pull/38806

-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------
File                         | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                                           
-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------
All files                    |   88.39 |    77.14 |   83.92 |    88.7 |                                                             
 apps/dav/src/views          |   70.58 |       50 |   16.66 |   70.58 |                                                             
  CalDavSettings.vue         |   70.58 |       50 |   16.66 |   70.58 | 128-320                                                     
 apps/files/src              |       0 |        0 |       0 |       0 |                                                             
  logger.js                  |       0 |        0 |       0 |       0 |                                                             
 apps/files/src/actions      |     100 |      100 |     100 |     100 |                                                             
  deleteAction.ts            |     100 |      100 |     100 |     100 |                                                             
  downloadAction.ts          |     100 |      100 |     100 |     100 |                                                             
  openFolderAction.ts        |     100 |      100 |     100 |     100 |                                                             
  sidebarAction.ts           |     100 |      100 |     100 |     100 |                                                             
 apps/files/src/services     |   65.95 |    55.88 |   73.33 |    65.9 |                                                             
  FileAction.ts              |   65.95 |    55.88 |   73.33 |    65.9 | 117-121,126,130,134,138,143,147,151,155,159,163,177-178,185 
 apps/files_sharing/src/lib  |     100 |      100 |     100 |     100 |                                                             
  SharePermissionsToolBox.js |     100 |      100 |     100 |     100 |                                                             
 core/src/OC                 |     100 |      100 |     100 |     100 |                                                             
  requesttoken.js            |     100 |      100 |     100 |     100 |                                                             
-----------------------------|---------|----------|---------|---------|-------------------------------------------------------------

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Jun 14, 2023
@skjnldsv skjnldsv self-assigned this Jun 14, 2023
@skjnldsv skjnldsv changed the title [wip] fix: delete action import [wip] Add files actions testing Jun 20, 2023
@skjnldsv skjnldsv requested review from a team, susnux, artonge and Pytal and removed request for a team June 20, 2023 14:49
@skjnldsv skjnldsv marked this pull request as ready for review June 20, 2023 14:49
@skjnldsv skjnldsv changed the title [wip] Add files actions testing Add files actions testing Jun 20, 2023
@skjnldsv skjnldsv added 3. to review Waiting for reviews technical debt and removed 2. developing Work in progress labels Jun 20, 2023
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv requested a review from artonge June 20, 2023 16:31
@skjnldsv skjnldsv mentioned this pull request Jun 2, 2023
Closed
6 tasks
@skjnldsv
fix: delete action import
8b5ef98 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: prepare jest upgrade and ts testing
f8e697c 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add sidebar action testing
c31b232 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add delete action testing
9fbdc00 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add download action testing
1b0848a 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: add open folder action testing
8096315 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
fix(jest): replace mock with jest.spyOn
70ee8de 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
feat: prepare jest coverage support
45ecd55 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv changed the title Add files actions testing Add files actions testing + code coverage Jun 21, 2023
@skjnldsv
chore: update old codecov config
8971148 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
chore: add __tests__ and __mocks__ to file checker and fix update…
a70aa61 
…d names

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
nickvergessen
nickvergessen approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks okay and still renders

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 21, 2023
@skjnldsv skjnldsv merged commit 32bbe3d into master Jun 21, 2023
@skjnldsv skjnldsv deleted the feat/f2v/actions-1 branch June 21, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files technical debt
Projects
Files to vue
Status: Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @nickvergessen @artonge