Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): Also abort the request when reaching max delay in af… #38274

Merged

Conversation

nickvergessen
Copy link
Member

…terController

Best reviewed with ?w=1

…terController

Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the diff much shorter in backports?

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, it’s because attribute are supported on master and not on previous versions

@nickvergessen nickvergessen merged commit 5e02def into master May 16, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/reach-max-delay-in-afterController branch May 16, 2023 09:07
@blizzz blizzz mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants