Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #38200

Merged
merged 3 commits into from
May 12, 2023
Merged

Update CODEOWNERS #38200

merged 3 commits into from
May 12, 2023

Conversation

bigcat88
Copy link
Member

task from @DaphneMuller

@bigcat88
Copy link
Member Author

Probably someone should add write access to this repo for
https://github.com/orgs/nextcloud/teams

I do not know how to do that(

nickvergessen
nickvergessen requested changes May 11, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per discussion the CODEOWNER should be mapped to the /appinfo/info.xml for the apps.
Whether or not the owners fully subscribe to the apps path is up to them

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@DaphneMuller
Copy link

hey @nickvergessen , shall we have a chat about it 1:1? I tasked Alexander with this. The idea is that community PR's get assigned faster to the right people. I don't see why what Alexander did is a problem for you, maybe you can rephrase or explain me?

@ChristophWurst
Copy link
Member

For transparency please keep the discussion here

ChristophWurst
ChristophWurst requested changes May 11, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristophWurst vs @Pytal

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed May 12, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
bigcat88 and others added 2 commits May 12, 2023 10:58
@bigcat88 @nickvergessen
Update CODEOWNERS
fa4bd16 
task from @DaphneMuller 

Signed-off-by: Alexander Piskun <13381981+bigcat88@users.noreply.github.com>
@nickvergessen
Order owner groups
2ad2fdd 
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
nickvergessen approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reordered the groups and added "section headlines"

@nickvergessen nickvergessen added this to the Nextcloud 27 milestone May 12, 2023
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label May 12, 2023
ChristophWurst
ChristophWurst requested changes May 12, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked my own responsibilities but not any other mapping of gmbh employees to this code owners file

.github/CODEOWNERS Outdated Show resolved Hide resolved
@nickvergessen @ChristophWurst
Fix more Christoph(er) mixups
dc190f4 
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
ChristophWurst
ChristophWurst approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

Looks ok but didn't check every owner in detail

@nickvergessen
Copy link
Member

Please squash

Or we save the precious CI time since 5 jobs finished already.

@ChristophWurst
Copy link
Member

Reabse with skipci

@bigcat88
Copy link
Member Author

bigcat88 commented May 12, 2023 •
edited
Loading

Reabse with skipci

should I create a new PR with these changes and [skip ci] or someone else will do it?

P.S: auto merge is set...

@nickvergessen nickvergessen merged commit b520a13 into master May 12, 2023
@nickvergessen nickvergessen deleted the codeowners-patch branch May 12, 2023 11:36
@welcome
Copy link

welcome bot commented May 12, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@blizzz blizzz mentioned this pull request May 12, 2023
Merged
@Pytal Pytal mentioned this pull request May 16, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@bigcat88 @DaphneMuller @ChristophWurst @nickvergessen @Pytal