Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable UserStatus#clearStatus route #38099

Merged
merged 1 commit into from
May 9, 2023

Conversation

provokateurin
Copy link
Member

Summary

I noticed the endpoint at

public function clearStatus(): DataResponse {
doesn't have a route and therefore is unreachable.

Checklist

@provokateurin provokateurin requested review from a team, ArtificialOwl, Fenn-CS and come-nc and removed request for a team May 5, 2023 12:19
@provokateurin provokateurin added this to the Nextcloud 27 milestone May 5, 2023
@nickvergessen
Copy link
Member

So maybe we remove the endpoint code instead of adding a route? :P
Can't find the ticket at the moment, but there was also the plan to make the current revert status message also reverts the status.

@provokateurin
Copy link
Member Author

Either way is fine for me, I just don't want to have an unused method in a controller.

@nickvergessen
Copy link
Member

Yeah let's drop it then for now. If we ever need it (and didn't in the last 3 years), we can add it.

Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin provokateurin force-pushed the fix/missing-clear-status-route branch from 892deea to e6e2b87 Compare May 8, 2023 12:17
@provokateurin provokateurin changed the title Add missing route for UserStatus#clearStatus Remove unreachable UserStatus#clearStatus route May 8, 2023
@skjnldsv skjnldsv merged commit 14a468f into master May 9, 2023
@skjnldsv skjnldsv deleted the fix/missing-clear-status-route branch May 9, 2023 06:24
This was referenced May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants