Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use more efficient tag retrieval on DAV report request #37969

Merged
merged 14 commits into from
Jun 28, 2023

Commits on Jun 21, 2023

  1. use efficient tag retrieval on DAV report request

    - uses DAV search approach against valid files joined by systemtag selector
    - reduced table join for tag/systemtag search
    - supports pagination
    - no changes to the output formats or similar
    
    Example request body:
    
    <?xml version="1.0"?>
    <oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
      <d:prop>
        <d:getcontentlength/>
        <d:getcontenttype/>
        <d:getetag/>
        <d:getlastmodified/>
        <d:resourcetype/>
        <nc:face-detections/>
        <nc:file-metadata-size/>
        <nc:has-preview/>
        <nc:realpath/>
        <oc:favorite/>
        <oc:fileid/>
        <oc:permissions/>
        <nc:nbItems/>
      </d:prop>
      <oc:filter-rules>
        <oc:systemtag>32</oc:systemtag>
      </oc:filter-rules>
      <d:limit>
        <d:nresults>50</d:nresults>
        <nc:firstresult>0</nc:firstresult>
      </d:limit>
    </oc:filter-files>
    
    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    58f7fd2 View commit details
    Browse the repository at this point in the history
  2. fix: change if with conditionless else to switch; and a parameter value

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b0d1cf5 View commit details
    Browse the repository at this point in the history
  3. fix: favorites view and universal search against tags

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    783e32a View commit details
    Browse the repository at this point in the history
  4. fix: ensure searchBySystemTag() is available

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    be50bd1 View commit details
    Browse the repository at this point in the history
  5. chore: cleanup unused code

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ddb65be View commit details
    Browse the repository at this point in the history
  6. fix: no search when LazyFolder was provided

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    30028bb View commit details
    Browse the repository at this point in the history
  7. feat: add searchBySystemTag as PHP API

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    221562d View commit details
    Browse the repository at this point in the history
  8. fix: search with more than one search tags

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    29f59a5 View commit details
    Browse the repository at this point in the history
  9. fix: include invisible tags for admins

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    49db546 View commit details
    Browse the repository at this point in the history
  10. fix: cominbation of small fixes

    - possible null return
    - parameter name mismatch in implementation
    - incomplete unit test
    
    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a0f9556 View commit details
    Browse the repository at this point in the history
  11. fix: obey offset and limit for results from favs and circles

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    27f6f86 View commit details
    Browse the repository at this point in the history
  12. fix: use array_unitersect against objects

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    a0b6834 View commit details
    Browse the repository at this point in the history
  13. refactor: save unnecessary method_exists

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    00b396a View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. fix: cannot apply limit+offset on multi-tag-search

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    blizzz committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d948710 View commit details
    Browse the repository at this point in the history