Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an admin check for db file locking #37766

Merged
merged 2 commits into from
Apr 18, 2023
Merged

add an admin check for db file locking #37766

merged 2 commits into from
Apr 18, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Apr 17, 2023 •
edited
Loading

@szaimen szaimen added the 2. developing Work in progress label Apr 17, 2023
@szaimen szaimen added this to the Nextcloud 27 milestone Apr 17, 2023
@szaimen szaimen force-pushed the enh/noid/add-db-file-locking-check branch 3 times, most recently from 0ff5e1e to 45b2913 Compare April 17, 2023 10:48
@szaimen szaimen added enhancement 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 17, 2023
@szaimen szaimen marked this pull request as ready for review April 17, 2023 10:48
@szaimen szaimen requested review from nickvergessen, juliusknorr, a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team April 17, 2023 10:49
@szaimen
add an admin check for db file locking
80645a5 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/noid/add-db-file-locking-check branch from 45b2913 to 80645a5 Compare April 17, 2023 10:51
@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 17, 2023
nickvergessen
nickvergessen requested changes Apr 17, 2023
View reviewed changes
core/js/setupchecks.js Outdated Show resolved Hide resolved
@szaimen
address review and fix tests
e2ab9bf 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 18, 2023
@szaimen szaimen enabled auto-merge April 18, 2023 09:51
@szaimen szaimen merged commit 1a25537 into master Apr 18, 2023
@szaimen szaimen deleted the enh/noid/add-db-file-locking-check branch April 18, 2023 11:31
@ngc7331 ngc7331 mentioned this pull request Jun 16, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@pulsejet pulsejet pulsejet approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @nickvergessen @pulsejet