Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typed version of IConfig::getSystemValue as much as possible #37596

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Use typed version of IConfig::getSystemValue as much as possible #37596

merged 3 commits into from
Apr 21, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 5, 2023 •
edited
Loading

Summary

Use getSystemValueString/getSystemValueBool/getSystemValueInt as much as possible to improve typing.
We may want to add getSystemValueArray.

Checklist

@come-nc
Use typed version of IConfig::getSystemValue as much as possible
426c034 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 2. developing Work in progress label Apr 5, 2023
@come-nc come-nc self-assigned this Apr 5, 2023
@come-nc come-nc added this to the Nextcloud 27 milestone Apr 5, 2023
@come-nc
Adapt tests to config value typing
8d5165e 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 17, 2023
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team April 17, 2023 08:44
@come-nc
Merge branch 'master' into enh/type-iconfig-getter-calls
b294eda 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@icewind1991 icewind1991 merged commit ccab101 into master Apr 21, 2023
@icewind1991 icewind1991 deleted the enh/type-iconfig-getter-calls branch April 21, 2023 11:48
@SwikritiT SwikritiT mentioned this pull request Apr 25, 2023
Merged
@Pytal Pytal mentioned this pull request May 4, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@blizzz blizzz blizzz approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @icewind1991 @blizzz