Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix files breadcrumb spacing #36855

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Fix files breadcrumb spacing #36855

merged 1 commit into from
Feb 28, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Feb 24, 2023 •
edited
Loading

Before After
2023-02-24_17-19_1 image

@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews 26-feedback labels Feb 24, 2023
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Feb 24, 2023
@skjnldsv skjnldsv self-assigned this Feb 24, 2023
@skjnldsv skjnldsv requested review from artonge, juliusknorr, a team, Pytal and szaimen and removed request for a team February 24, 2023 16:21
@come-nc
Copy link
Contributor

come-nc commented Feb 27, 2023

Looking at the screenshot it seems to me the + button is not aligned perfectly with the home and ">" icons on the after screenshot, while it was before?

artonge
artonge approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok besides Côme's comment

@skjnldsv
Fix files breadcrumb spacing
deffe76 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv
Copy link
Member Author

image

Fixed

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 28, 2023
@AndyScherzinger AndyScherzinger merged commit eac542d into master Feb 28, 2023
@AndyScherzinger AndyScherzinger deleted the fix/bread-padding branch February 28, 2023 15:23
@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish 26-feedback bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @come-nc @AndyScherzinger @artonge @Pytal