Remove extraneous Node.js core module dependencies #36842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- buffer and stream-browserify are already provided by node-polyfill-webpack-plugin Signed-off-by: Christopher Ng <chrng8@gmail.com>
|
/backport to stable25 |
artonge
approved these changes
Feb 27, 2023
skjnldsv
approved these changes
Feb 27, 2023
is that necessary? If it's not a bugfix, then no backports :) |
Not necessary, but would be redundant after #36841 |
Pytal
added
4. to release
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the extraneous Node.js core module dependencies,
bufferandstream-browserify, as they are already provided by https://github.com/Richienb/node-polyfill-webpack-pluginCompiled js remains unchanged
Checklist