add a disk_free_space check before writing config #36691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991,
blizzz and
come-nc
and removed request for
a team
st3iny
reviewed
Feb 13, 2023
szaimen
force-pushed
the
fix/25175/fix-config-truncating
branch
from
f9d8ecc
to
c03d3ae
Compare
come-nc
approved these changes
Feb 13, 2023
szaimen
commented
Feb 13, 2023
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
fix/25175/fix-config-truncating
branch
from
c03d3ae
to
9b6e5c6
Compare
Signed-off-by: Simon L <szaimen@e.mail.de>
mejo-
approved these changes
Feb 15, 2023
|
CI failure unrelated |
|
/backport to stable25 |
|
/backport to stable24 |
This was referenced Feb 15, 2023
Merged
|
At least on my 32-bit instance this breaks the update. I just removed EDIT: Ah, already addressed here: #36759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25175
Idea: the config file should simply not get written if disk space is low. Instead the current process should be exited. This should hopefully fix such issues in the future.
I am using the same logic in AIO and it works great over there.
https://github.com/nextcloud/all-in-one/blob/feffba739ae5ef2911782514fa5de367d52cf811/php/src/Data/ConfigurationManager.php#L455-L458