also cache backend for user in memory instead of always going to redis #36639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
come-nc
and removed request for
a team
icewind1991
force-pushed
the
userbackend-local-cache
branch
2 times, most recently
from
478249b
to
295d5ee
Compare
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
userbackend-local-cache
branch
from
295d5ee
to
b04d442
Compare
come-nc
approved these changes
Feb 9, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
userbackend-local-cache
branch
from
b04d442
to
853ec60
Compare
ChristophWurst
approved these changes
Feb 15, 2023
| use OCP\ICache; | ||
|
|
||
| /** | ||
| * Wrap a cache instance with an extra later of local, in-memory caching |
Merged
|
@icewind1991 Any specific reason to only put this as a private API? I could imagine this might be useful for app developers as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote caches aren't that cheap.
There are probably some other cases that do this manually that can be replaced with
WithLocalCache, but that is left as an exercise for a follow up PR.