Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Add option to return an exit-code when occ status signals an update is needed #36218

Merged
merged 3 commits into from
Feb 24, 2023
Merged

[stable25] Add option to return an exit-code when occ status signals an update is needed #36218

merged 3 commits into from
Feb 24, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #35873

Lee Garrett and others added 3 commits January 18, 2023 13:50
@backportbot-nextcloud
Implement occ status command via return codes (Fixes: #35704)
9851c86 
Running `./occ status -e` will produce any output. However, it will:

exit 0 during normal operation,
exit 1 when in maintenance mode,
exit 2 when `./occ upgrade` is needed.

Signed-off-by: Lee Garrett <lgarrett@rocketjump.eu>
@nickvergessen @backportbot-nextcloud
Print output also with status code
02ded7f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen @backportbot-nextcloud
No output by default when --exit-code is used
87678c2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.4 milestone Jan 18, 2023
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
blizzz
blizzz reviewed Feb 7, 2023
View reviewed changes
core/Command/Status.php
Comment on lines +73 to +75
if ($input->getOption('verbose') || !$input->getOption('exit-code')) {
$this->writeArrayInOutputFormat($input, $output, $values);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do I oversee something? Previously it was outputted independent of the verbose setting, but this changed now. I'd consider it a behavioral change which is not OK for a backport.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but default is !exit-code so the old behaviour persists

@blizzz
Copy link
Member

blizzz commented Feb 9, 2023

moving to 25.0.5

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Feb 24, 2023
@nickvergessen
Copy link
Member

@leegarrett want to approve the backport?

@leegarrett leegarrett self-requested a review February 24, 2023 11:52
@nickvergessen nickvergessen merged commit bbcfa69 into stable25 Feb 24, 2023
@nickvergessen nickvergessen deleted the backport/35873/stable25 branch February 24, 2023 13:01
@blizzz blizzz mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz left review comments

@nickvergessen nickvergessen nickvergessen approved these changes

@leegarrett leegarrett leegarrett approved these changes

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feature: occ
Projects
None yet
Milestone
Nextcloud 25.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @nickvergessen @leegarrett