Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview: fix HEIC orientation #35689

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Conversation

pulsejet
Copy link
Member

@pulsejet pulsejet commented Dec 8, 2022

iOS camera images previews are not correctly oriented with HEIC for portrait. This fixes the orientation. A sample image is attached (zip cause GitHub forbids HEIC).

Request: please backport to 25.

IMG_5820.zip

@skjnldsv
Copy link
Member

skjnldsv commented Dec 9, 2022

/backport to stable25

@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member

skjnldsv commented Dec 9, 2022

@pulsejet if you want you have permissions to create branches here :)

@skjnldsv
Copy link
Member

skjnldsv commented Dec 9, 2022

@pulsejet if you want you have permissions to create branches here :)

The rebase bot didn't have the permission to rebase your fork.
Please rebase to latest master for tests to pass :)

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@pulsejet
Copy link
Member Author

pulsejet commented Dec 9, 2022

Ah, I see. I'll use branches henceforth; thanks for the heads up!

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@skjnldsv
Copy link
Member

skjnldsv commented Dec 11, 2022

I do not get why those two tests are failing... 🙈

  User default background settings
    ✓ See the user background settings (14295ms)
    (Attempt 1 of 3) Default cloud background is not rendered
    (Attempt 2 of 3) Default cloud background is not rendered
    1) Default cloud background is not rendered
    ✓ Default is selected on new users (66ms)

  User select a bright custom color and remove background
    ✓ See the user background settings (5759ms)
    (Attempt 1 of 3) Remove background
    (Attempt 2 of 3) Remove background
    2) Remove background
    ✓ Select a custom color (1269ms)
    ✓ See the header being inverted (221ms)
    ✓ Select a shipped background (1312ms)
    ✓ See the header NOT being inverted (79ms)

I think this is from the fork. No clue why, I will merge and see

@skjnldsv skjnldsv merged commit 4aafba6 into nextcloud:master Dec 11, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Dec 11, 2022

https://github.com/nextcloud/server/actions/runs/3668510626

EDIT: all good! No clue why the fork was failing

@szaimen
Copy link
Contributor

szaimen commented Dec 11, 2022

/backport to stable24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants