Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup contactsinteraction #35426

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Cleanup contactsinteraction #35426

merged 1 commit into from
Nov 30, 2022

Conversation

CarlSchwan
Copy link
Member

  • Add more typing and use PHP 7.4 typed properties

@CarlSchwan
Cleanup contactsinteraction
6828a3b 
- Add more typing and use PHP 7.4 typed properties

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Nov 25, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 26 milestone Nov 25, 2022
@CarlSchwan CarlSchwan self-assigned this Nov 25, 2022
tcitworld
tcitworld approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

miaulalala
miaulalala approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 28, 2022
@CarlSchwan CarlSchwan merged commit f4adfd1 into master Nov 30, 2022
@CarlSchwan CarlSchwan deleted the cleanup/contactintegration branch November 30, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@CarlSchwan @tcitworld @miaulalala @ChristophWurst