Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Fix settings for setting default expiration date #35215

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 16, 2022

  • ⚠️ This backport had conflicts and is incomplete

backport of #35210

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PVince81 are you sure about this being present on 24?

@PVince81
Copy link
Member

@szaimen yes, 24 is where I tested it first. but the second part of the fix is not needed and got discarded automatically

@PVince81
Copy link
Member

wait, no. the conflict is only the compiled assets

@PVince81
Copy link
Member

/compile amend /

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me then

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv added bug 4. to release Ready to be released and/or waiting for tests to finish regression labels Nov 16, 2022
@szaimen szaimen merged commit c091ffc into stable24 Nov 16, 2022
@szaimen szaimen deleted the backport/35210/stable24 branch November 16, 2022 22:36
@blizzz blizzz mentioned this pull request Nov 21, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants