Show info in admin settings about PHP opcache if disabled #3489
Conversation
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @rullzer and @nickvergessen to be potential reviewers. |
| $this->urlGenerator->expects($this->at(3)) | ||
| ->method('linkToDocs') | ||
| ->with('admin-code-integrity') | ||
| ->willReturn('http://doc.owncloud.org/server/go.php?to=admin-code-integrity'); |
There was a problem hiding this comment.
tiny nitpick... but why not use our own domain ;)?
There was a problem hiding this comment.
That's the other check I and I would like to keep them in sync with the code above :/
MorrisJobke
force-pushed
the
give-hint-about-opcache
branch
from
6608b05
to
65f126f
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
give-hint-about-opcache
branch
from
65f126f
to
cee8853
Compare
Codecov Report
@@ Coverage Diff @@
## master #3489 +/- ##
===========================================
+ Coverage 54.29% 54.8% +0.51%
- Complexity 21073 21513 +440
===========================================
Files 1311 1311
Lines 80414 81961 +1547
Branches 1252 1282 +30
===========================================
+ Hits 43662 44920 +1258
- Misses 36752 37041 +289
Continue to review full report at Codecov.
|
| { | ||
| docLink: data.phpOpcacheDocumentation, | ||
| } | ||
| ) + "<pre><code>opcache.enable=On\nopcache.enable_cli=1\nopcache.interned_strings_buffer=8\nopcache.max_accelerated_files=10000\nopcache.memory_consumption=128\nopcache.save_comments=1\nopcache.revalidate_freq=1</code></pre>", |
There was a problem hiding this comment.
opcache.enabled=On and opcache.enabled_cli=1? Can you make both 1?
There was a problem hiding this comment.
No - this somehow doesn't work. opcache.enabled works here on Ubuntu 16.04 only with On ... all other options with 1. I'm confused as well 😕
There was a problem hiding this comment.
http://php.net/manual/en/opcache.configuration.php really odd then:
Name Default Changeable Changelog
opcache.enable "1" PHP_INI_ALL
There was a problem hiding this comment.
http://php.net/manual/en/opcache.configuration.php really odd then:
I know. But better be on the safe side for this.
|
Documentation: nextcloud/documentation#367 |
I tried really hard to write unit tests for this, but it's simply not possible to change those settings during runtime. 😢