Fix size calculation on copying the skeleton files #34834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the filecache will have a wrong size for skeleton files Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
icewind1991,
CarlSchwan,
a team and
come-nc
and removed request for
a team
come-nc
approved these changes
Nov 3, 2022
|
backports needed ? |
|
Yes, would be good. |
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
This was referenced Nov 9, 2022
|
Brings a strange regression on 24 + 23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use proper storage methods to copy the skeleton files as otherwise the size propagation for the newly added files (and the user quota usage) will be wrong after the first login with object storage.
For local storage this works fine as the files are getting scanned afterwards.