Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert minimum length for tags #34642

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Oct 17, 2022

Revert e1d9b0b from #34096

Joas:

Need to have a submit button then, 3 characters is too long for some languages
(where even names can be a single character)
It' fine to not automatically search, but it needs to be submitable.
Similar like the normal unified search etc

Community:

The reason would be that nothing is displayed so you have to click and type three characters (four actions)
with no option to one click on a tag (as before).
It feels like a regression for tag users. Example, a small tag user only needs to see a limited number of tags.
Or, you are simply re-using the same tag over and over.

https://help.nextcloud.com/t/collaborative-tags-no-longer-visible-in-25-until-user-inputs-3-characters/147647

@kesselb kesselb self-assigned this Oct 17, 2022
@kesselb kesselb changed the title Revert minimum lenght for tags Revert minimum length for tags Oct 17, 2022
@kesselb
Copy link
Contributor Author

kesselb commented Oct 17, 2022

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Oct 20, 2022

Conflicts

@TheNomad11
Copy link

Is this issue still on your todo list or do you prefer to leave it like it is?

In my case, I have lots of tags with only two letters (for documents relating to language level A1, A2, B1 and B2), so now my whole organisation of files is no longer usable. Furthermore, I don't remember all the other tags that I have used, and there is no way to see previously used tags. The tagging system could be such a powerful tool in Nextcloud, now with version 25 it is totally broken. So at least I hope that you consider reverting the minimum length of tags. Thanks a lot!

@szaimen
Copy link
Contributor

szaimen commented Nov 5, 2022

@kesselb ? :)

This reverts commit e1d9b0b.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the bug/noid/revert-minimum-lenght-for-tags branch from a961984 to e665c81 Compare November 7, 2022 14:24
@kesselb
Copy link
Contributor Author

kesselb commented Nov 7, 2022

Hey, rebased the branch and recompiled the assets.

@szaimen szaimen requested review from a team, artonge and szaimen and removed request for a team November 7, 2022 16:08
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv merged commit b45c62a into master Nov 24, 2022
@skjnldsv skjnldsv deleted the bug/noid/revert-minimum-lenght-for-tags branch November 24, 2022 11:17
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants