-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable translucency on high contrast themes #34545
Conversation
Fix #34514 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
master is 26 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to fix fhe variable for these themes. See
$colorMainBackgroundRGB = join(',', $this->util->hexToRGB($colorMainBackground)); |
'--color-main-background-rgb' => $colorMainBackgroundRGB, |
@szaimen I'm not sure I understand correctly what you mean here. What is the problem with this variables? |
in high contrast mode dark is |
Contrast is already 17 this is already way higher than the required contrast for AAA. High contrast theme doesn't mean black on white theme ;) |
fine but it is still wrong. will push the change to the branch shortly |
Signed-off-by: szaimen <szaimen@e.mail.de>
done with f1b3842 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now but didn't test
/backport to stable25 |
Fix #34514