Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix excessive increase of cachebuster value #34543

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #34473

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: theming regression labels Oct 11, 2022
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25 milestone Oct 11, 2022
@blizzz blizzz mentioned this pull request Oct 11, 2022
2 tasks
@blizzz blizzz added the 3. to review Waiting for reviews label Oct 11, 2022
@szaimen
Copy link
Contributor

szaimen commented Oct 12, 2022

CI failure unrelated

@szaimen szaimen merged commit be7b7f5 into stable25 Oct 12, 2022
@szaimen szaimen deleted the backport/34473/stable25 branch October 12, 2022 05:54
@AndyXheli
Copy link

Just applied this patch on my NC 25 RC3. As of right now the Icons are back and no longer seeing the below errors. Patch was applied 6 min ago error logs show from 41 min to an hour ago

image

@Pytal
Copy link
Member

Pytal commented Oct 13, 2022

Great to hear @AndyXheli! feel free to open an issue if you find any bugs :)

@AndyXheli
Copy link

@Pytal

Just got this going from NC 24.0.6 to NC 25.0.1 RC1 should i create a new ticket regaring this ?

OCP\Files\NotPermittedException: Could not create folder

{"reqId":"TMod8jonQTy9dGEggrnp","level":3,"time":"2022-10-27T15:39:51-05:00","remoteAddr":"66.158.36.34","user":"axheli","app":"index","method":"GET","url":"/apps/theming/img/core/filetypes/image.svg?v=21","message":"Could not create folder","userAgent":"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36","version":"25.0.1.0","exception":{"Exception":"OCP\Files\NotPermittedException","Message":"Could not create folder","Code":0,"Trace":[{"file":"/var/www/nextcloud/lib/private/Files/SimpleFS/SimpleFolder.php","line":106,"function":"newFolder","class":"OC\Files\Node\Folder","type":"->"},{"file":"/var/www/nextcloud/apps/theming/lib/ImageManager.php","line":165,"function":"newFolder","class":"OC\Files\SimpleFS\SimpleFolder","type":"->"},{"file":"/var/www/nextcloud/apps/theming/lib/ImageManager.php","line":180,"function":"getCacheFolder","class":"OCA\Theming\ImageManager","type":"->"},{"file":"/var/www/nextcloud/apps/theming/lib/Controller/IconController.php","line":90,"function":"getCachedImage","class":"OCA\Theming\ImageManager","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":225,"function":"getThemedIcon","class":"OCA\Theming\Controller\IconController","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":133,"function":"executeController","class":"OC\AppFramework\Http\Dispatcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/AppFramework/App.php","line":172,"function":"dispatch","class":"OC\AppFramework\Http\Dispatcher","type":"->"},{"file":"/var/www/nextcloud/lib/private/Route/Router.php","line":298,"function":"main","class":"OC\AppFramework\App","type":"::"},{"file":"/var/www/nextcloud/lib/base.php","line":1047,"function":"match","class":"OC\Route\Router","type":"->"},{"file":"/var/www/nextcloud/index.php","line":36,"function":"handleRequest","class":"OC","type":"::"}],"File":"/var/www/nextcloud/lib/private/Files/Node/Folder.php","Line":165,"CustomMessage":"--"},"id":"635aed9472be6"}

@Pytal
Copy link
Member

Pytal commented Oct 27, 2022

Please do @AndyXheli :)

@AndyXheli
Copy link

Please do @AndyXheli :)

Created :) for you for the reply nextcloud/photos#1498

@Pytal
Copy link
Member

Pytal commented Oct 27, 2022

Created :) for you for the reply nextcloud/photos#1498

Thanks!

@AndyXheli
Copy link

Created :) for you for the reply nextcloud/photos#1498

Thanks!

Youre welcome! Thank you ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: theming regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants