Update security.txt expires field #34522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/34480/update-security.txt-expires-field
branch
from
d789d56
to
46070cf
Compare
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
szaimen
approved these changes
Oct 11, 2022
tcitworld
approved these changes
Oct 11, 2022
nickvergessen
deleted the
bugfix/34480/update-security.txt-expires-field
branch
This was referenced Oct 11, 2022
BartG95
reviewed
Nov 3, 2022
| @@ -38,10 +38,11 @@ public function handle(string $service, IRequestContext $context, ?IResponse $pr | |||
| } | |||
|
|
|||
| $response = "Contact: https://hackerone.com/nextcloud | |||
| Expires: 2021-12-31T23:00:00.000Z | |||
| Expires: 2023-04-31T23:00:00.000Z | |||
There was a problem hiding this comment.
April has thirty days, not thirty-one....
This makes various security.txt checkers, such as internet.nl, tell me that the expires field is invalid.
There was a problem hiding this comment.
Ouch, that's right. Unluckily the next maintenance releases just went out, so a fox will have to wait until in 4 weeks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34480